Skip to content

surefire: ignore system classloader to make tests run#3038

Merged
yadvr merged 1 commit intoapache:4.11from
shapeblue:surefix-facepalm-fix
Nov 20, 2018
Merged

surefire: ignore system classloader to make tests run#3038
yadvr merged 1 commit intoapache:4.11from
shapeblue:surefix-facepalm-fix

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Nov 19, 2018

Due to issue described in Surefix bug:
https://issues.apache.org/jira/browse/SUREFIRE-1588

Debian-based users/developers can no longer build CloudStack 4.11+
branches. The other workaround is to have the following jvm property:
jdk.net.URLClassPath.disableClassPathURLCheck=true

The other workaround is to skipTests (not ideal). Developers can continue to use
-Djdk.net.URLClassPath.disableClassPathURLCheck=true with mvn.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Due to issue described in Surefix bug:
https://issues.apache.org/jira/browse/SUREFIRE-1588

Debian-based users/developers can no longer build CloudStack 4.11+
branches. The other workaround is to have the following jvm property:
jdk.net.URLClassPath.disableClassPathURLCheck=true

Signed-off-by: Rohit Yadav <rohit@apache.org>
@yadvr
Copy link
Member Author

yadvr commented Nov 19, 2018

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✖centos7 ✔debian. JID-2445

@yadvr
Copy link
Member Author

yadvr commented Nov 19, 2018

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2446

@yadvr
Copy link
Member Author

yadvr commented Nov 19, 2018

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@andrijapanic-dont-use-this-one

LGTM

tested by manually changing POM file and successfully built packages (4.11.2-RC5) on Ubuntu 18.04, OpenJDK 1.8.0_181

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rhtyd!

@ustcweizhou
Copy link
Contributor

LGTM

build 4.11.2-RC successfully on centos7, ubuntu 16.04 and ubuntu 18.04 with this change

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will build on macos and fedora to evaluate but looks good and small enough to easily remedy if it doesn't.

@yadvr
Copy link
Member Author

yadvr commented Nov 20, 2018

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3191)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23239 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3038-t3191-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 66 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces Error 166.67 test_internal_lb.py
test_05_rvpc_multi_tiers Failure 311.67 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 333.40 test_vpc_redundant.py

@PaulAngus
Copy link
Member

@rhtyd - this looks go to merge - should we have blue orangutan build using an a ubuntu 18.04 docker image going forward?

@yadvr
Copy link
Member Author

yadvr commented Nov 20, 2018

@PaulAngus maybe we can have the test matrix run one of three envs as ubuntu 18.04 based mgmt server. Since we still support ubuntu 16.04,we'll need to build pkgs on Ubuntu 16.04 based docker image.

@yadvr yadvr merged commit fbb0d92 into apache:4.11 Nov 20, 2018
@yadvr yadvr deleted the surefix-facepalm-fix branch November 20, 2018 15:44
@DaanHoogland
Copy link
Contributor

for the record: macos(10.14.1) and fedora(28) builds pass

Tonitzpp pushed a commit to scclouds/cloudstack that referenced this pull request Dec 18, 2025
Corrige limites de recurso de projetos

Closes apache#3038

See merge request scclouds/scclouds!1277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants